Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apple GPU runners and run Metal tests again #18817

Open
ScottTodd opened this issue Oct 17, 2024 · 0 comments
Open

Add Apple GPU runners and run Metal tests again #18817

ScottTodd opened this issue Oct 17, 2024 · 0 comments
Labels
hal/metal Runtime Apple Metal HAL backend infrastructure Relating to build systems, CI, or testing platform/macos 🍎 MacOS-specific build, execution, benchmarking, and deployment

Comments

@ScottTodd
Copy link
Member

Similar to #18814.

We used to have a mac mini running macOS builds/tests, including of the Metal HAL. Right now we use standard GitHub-hosted runners for macOS, which includes arm (macos-12 and macos-13) and m1 (macos-14). The GitHub-hosted runners do not expose the GPU (at least on arm64?):

Nested-virtualization and Metal Performance Shaders (MPS) are not supported due to the limitation of Apple's Virtualization Framework.

We could start with a single self-hosted runner handling nightly jobs with unit tests and larger test suites, but we should aim for presubmit testing of at least the Metal unit tests.
@ScottTodd ScottTodd added hal/metal Runtime Apple Metal HAL backend infrastructure Relating to build systems, CI, or testing platform/macos 🍎 MacOS-specific build, execution, benchmarking, and deployment labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hal/metal Runtime Apple Metal HAL backend infrastructure Relating to build systems, CI, or testing platform/macos 🍎 MacOS-specific build, execution, benchmarking, and deployment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ScottTodd