Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or rework the iree_hal_buffer_fill/read/write/etc functions #4472

Closed
benvanik opened this issue Jan 12, 2021 · 0 comments · Fixed by #4571
Closed

Remove or rework the iree_hal_buffer_fill/read/write/etc functions #4472

benvanik opened this issue Jan 12, 2021 · 0 comments · Fixed by #4571
Labels
bug 🐞 Something isn't working hal/vulkan Runtime Vulkan GPU HAL backend

Comments

@benvanik
Copy link
Collaborator

The iree_hal_buffer_* functions for directly manipulating the buffer are not great. Vulkan doesn't have these (so we have to map memory), Metal doesn't have them or even a workaround that doesn't involve creating a command buffer and submitting it, and they are not guaranteed to work (as some backends may not support mapping memory).

Instead, we could make these functions take a command buffer to append operations to, or make them do the create command buffer + record + submit and wait themselves. Removing them entirely is probably best as they'll never be a good idea (can't work on device-local memory, inefficient on host-visible memory, etc).

@benvanik benvanik added bug 🐞 Something isn't working hal/vulkan Runtime Vulkan GPU HAL backend labels Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working hal/vulkan Runtime Vulkan GPU HAL backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant