Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lud16 onion support in iris.to #433

Open
sybip opened this issue Sep 13, 2023 · 1 comment
Open

lud16 onion support in iris.to #433

sybip opened this issue Sep 13, 2023 · 1 comment

Comments

@sybip
Copy link

sybip commented Sep 13, 2023

Hi, posting this on behalf of a nostrich who doesn't have a github account.

On the web version of iris.to, when zapping a note by a user whose lightning address is an onion address, the LNURLP GET request is attempted over HTTPS, and typically fails with "lnurl error". This is inconsistent with LUD16 2nd paragraph, which specifies that requests to onion endpoints should be over HTTP.

Any clarifications, please speak with Max at npub1nu6fe9qul69lwdelsvrh0hpfnh339s3a39368w2059ezxzpp7wsscj9cyc

Thanks in advance for looking into this.

@sybip
Copy link
Author

sybip commented Sep 13, 2023

Probably around here:

} else if (lnurl.match(/[\w.-]+@[\w.-]/)) {
const [handle, domain] = lnurl.split('@');
this.#url = new URL(`https://${domain}/.well-known/lnurlp/${handle}`);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant