Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[p3] Resetting for an incorrect height should trigger proper error messages #1553

Closed
shilei-wang opened this issue Jun 11, 2019 · 2 comments
Closed

[p3] Resetting for an incorrect height should trigger proper error messages #1553

shilei-wang opened this issue Jun 11, 2019 · 2 comments
Assignees
@haifengxi @chengwenxi @shilei-wang
Labels
bug Something isn't working state

Comments

@shilei-wang
Copy link
Contributor

shilei-wang commented Jun 11, 2019 •
edited
Loading

To Reproduce

  1. Suppose the current height is 1000, and terminate the iris.
  2. iris reset --height=2000 --home=****

output:
Reset app state to height 2000 successfully

Expected behavior
output:
Reset app state to latest height successfully

The same problem exists in " reset --height=0 "
@shilei-wang shilei-wang added the bug Something isn't working label Jun 11, 2019
@chengwenxi chengwenxi self-assigned this Jun 11, 2019
@haifengxi haifengxi changed the title [p3] In reset/export module, the client return the incorrect prompt while "reset height" > "latest height" [p3] Resetting for an incorrect height should trigger proper error messages Jun 11, 2019
@haifengxi
Copy link
Contributor

Related: #1511

@chengwenxi chengwenxi mentioned this issue Jun 13, 2019
Merged
@shilei-wang
Copy link
Contributor Author

confirm fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haifengxi haifengxi

@chengwenxi chengwenxi

@shilei-wang shilei-wang

Labels
bug Something isn't working state
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@haifengxi @chengwenxi @shilei-wang