Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print out progressing status when replaying large blocks #1554

Closed
shilei-wang opened this issue Jun 11, 2019 · 1 comment
Closed

Print out progressing status when replaying large blocks #1554

shilei-wang opened this issue Jun 11, 2019 · 1 comment
Assignees
@haifengxi @chengwenxi @shilei-wang
Labels
enhancement New feature or improvement state tendermint

Comments

@shilei-wang
Copy link
Contributor

Describe the bug
If the replay height is larger than 5000 blocks, the replay period is very long (maybe several minutes), we should give a appropriate prompt to user, not just suspend the program for several minutes.

To Reproduce

  1. Suppose current height is 20000
  2. iris reset --height=10000 --home=***
  3. iris start --home=****
    .... ....
    The user has to wait a very long time without any prompt.
    .... ....
@shilei-wang shilei-wang added bug Something isn't working enhancement New feature or improvement labels Jun 11, 2019
@shilei-wang shilei-wang changed the title [enhancement] It's necessary to give a appropriate prompt when replaying large blocks instead of suspend the program [enhancement] It's necessary to give an appropriate prompt when replaying large blocks instead of suspend the program Jun 11, 2019
@chengwenxi chengwenxi added tendermint and removed bug Something isn't working labels Jun 11, 2019
@haifengxi
Copy link
Contributor

Related: #1511

@haifengxi haifengxi changed the title [enhancement] It's necessary to give an appropriate prompt when replaying large blocks instead of suspend the program Print out progressing status when replaying large blocks Jun 11, 2019
@chengwenxi chengwenxi mentioned this issue Jun 27, 2019
Merged
This was referenced Apr 19, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haifengxi haifengxi

@chengwenxi chengwenxi

@shilei-wang shilei-wang

Labels
enhancement New feature or improvement state tendermint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@haifengxi @chengwenxi @shilei-wang