Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace time.Time with uint64 in coinswap msgs #1872

Closed
zhangyelong opened this issue Aug 14, 2019 · 1 comment
Closed

Replace time.Time with uint64 in coinswap msgs #1872

zhangyelong opened this issue Aug 14, 2019 · 1 comment
Assignees
Labels
coin-swap enhancement New feature or improvement

Comments

@zhangyelong
Copy link
Contributor

In order to be compatible with different language versions of the clients, we need to use uint64 to receive deadline in coinswap msgs instead of time.Time.

@zhangyelong zhangyelong added enhancement New feature or improvement coin-swap labels Aug 14, 2019
@zhangyelong zhangyelong self-assigned this Aug 14, 2019
@zhangyelong
Copy link
Contributor Author

zhangyelong commented Aug 14, 2019

Hmm, seems int64 is better
Because the system uses int64 for Unix Time conversion, Unix Time itself can be negative, representing the time before 1970. Although we will never use it, using int64 can prevent us from doing another meaningless conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coin-swap enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant