Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in inflight dependency #573

Closed
LakshmiPhani7680 opened this issue Dec 10, 2023 · 4 comments
Closed

Memory leak in inflight dependency #573

LakshmiPhani7680 opened this issue Dec 10, 2023 · 4 comments

Comments

@LakshmiPhani7680
Copy link

Hi,
I have inflight package still in version 10.0.2, the problem is if i remove this inflight package i am not able to use the npm commands so is there anyway to resolve this issue? and is there anyway to resolve this issue in 8.x versions of npm also? please respond as it was one of the main vulnerability in npm package.

@isaacs
Copy link
Owner

isaacs commented Dec 10, 2023

Run npm ls glob inflight and npm why inflight and share the output, please. Glob 10 does not use inflight.

@davidguilherme
Copy link

@isaacs loads of package still use glob v8 or less. From v9 the API changed from callbacks to promises, I think it would be reasonable to patch v8 so people can easily upgrade to (or even use overrides/resolution in the package.json). What do you think?

@frontzhm
Copy link

frontzhm commented Jan 4, 2024 via email

@isaacs
Copy link
Owner

isaacs commented Jan 4, 2024

I disagree. I'm not going to touch ancient versions of things. Fork it and patch if you want to do extra work to avoid upgrading, or override with a patched version of inflight. Not my job, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants