Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecation warning s/6/7/ #64

Closed
ChALkeR opened this issue May 5, 2016 · 3 comments
Closed

Update deprecation warning s/6/7/ #64

ChALkeR opened this issue May 5, 2016 · 3 comments

Comments

@ChALkeR
Copy link
Contributor

ChALkeR commented May 5, 2016

See #61 (comment) — that message is not correct.

Only a runtime warning landed in Node.js 6.0, that warning will be turned into a throw in Node.js 7.0.

Refs: nodejs/node#6413, nodejs/node#5213, nodejs/node#5102.
@ChALkeR ChALkeR mentioned this issue May 5, 2016
Closed
@ChALkeR
Copy link
Contributor Author

ChALkeR commented May 5, 2016

The initial graceful-fs deprecation message was fine, but it was mistakenly changed in #61.

@isaacs
Copy link
Owner

isaacs commented May 5, 2016

Aha! Sorry for my confusion. Updated deprecation warning. Thanks for the update.

@isaacs isaacs closed this as completed May 5, 2016
@ChALkeR
Copy link
Contributor Author

ChALkeR commented May 5, 2016

@isaacs Thanks!

@hgwood hgwood mentioned this issue May 31, 2016
Closed
@hgwood hgwood mentioned this issue Sep 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacs @ChALkeR