Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install using pip #129

Open
dotlambda opened this issue Jun 22, 2021 · 2 comments
Open

Install using pip #129

dotlambda opened this issue Jun 22, 2021 · 2 comments
Labels
enhancement New feature or request packaging

Comments

@dotlambda
Copy link

It would be nice if it was possible to install scli using pip. You should create a setup.py.

@exquo
Copy link
Collaborator

exquo commented Jun 23, 2021

That would be good!

The problem is the signal-cli dependency.
Simply including its release binaries in the pip package will not work on many systems. For one thing, it requires compiling the native libraries (libzkgroup and libsignal-client) that signal-cli itself depends on. (They are included for x86_64 linux with recent enough glibc; currently this excludes Debian stable, see AsamK/signal-cli#643). There are many other potential issues and incompatibilities that could arise on a given system configuration.

When software is packaged for easy installation, such as with pip, users can reasonably expect to be able to type pip install scli && scli and having everything to just work. I don't think we can guarantee that with the signal-cli requirement.


That being said, it might be worthwhile to package "the rest" of scli, so that users who already have signal-cli installed could install scli with just a call to pip. There's not much room to simplify the rest of the manual install procedure though, as it's currently just

git clone …/scli
pip install urwid
ln -s scli/scli ~/.local/bin  # or add to $PATH any other way

but there still might be some benefits from packaging (yet to be considered).


Any thoughts on resolving (or sidestepping) the above are welcome!

@exquo exquo added the enhancement New feature or request label Jun 23, 2021
@dotlambda
Copy link
Author

That being said, it might be worthwhile to package "the rest" of scli, so that users who already have signal-cli installed could install scli with just a call to pip.

That sounds perfectly reasonable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packaging
Projects
None yet
Development

No branches or pull requests

2 participants