1128 improve color matching #1166
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1128
This is the current implementation for CIELAB color matching which takes gaussian distance in 3D CIELAB space as a feature and creates a bounding sphere for per-object color values. We found that this approach is flawed, and can be improved by using the Mahalanobis distance to create a bounding range. More details are available in the write-up, located here: https://docs.google.com/document/d/1cTtY67oCg_8EX1lfU6srxbjPAPtC1NnpAx5RVXyFRlI/edit?usp=sharing