Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

iter_count is never incremented in min_norm_solvers? #39

Open
newalexander opened this issue Aug 22, 2021 · 0 comments
Open

iter_count is never incremented in min_norm_solvers? #39

newalexander opened this issue Aug 22, 2021 · 0 comments

Comments

@newalexander
Copy link

Both the find_min_norm_element (https://github.com/isl-org/MultiObjectiveOptimization/blob/master/multi_task/min_norm_solvers.py#L120) and find_min_norm_element_FW (https://github.com/isl-org/MultiObjectiveOptimization/blob/master/multi_task/min_norm_solvers.py#L166) functions define a while loop based on an iter_count variable.

Line 13 of Algorithm 2 in the paper (https://arxiv.org/pdf/1810.04650.pdf) notes that optimization is done until a number of iterations or convergence threshold is reached. However, the code never actually increments iter_count, and so optimization only terminates based on the convergence threshold.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant