Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animation to Modal component? #25

Open
danya02 opened this issue Aug 13, 2023 · 1 comment
Open

Add animation to Modal component? #25

danya02 opened this issue Aug 13, 2023 · 1 comment

Comments

@danya02
Copy link

danya02 commented Aug 13, 2023

Right now, the yew_bootstrap::component::Modal will appear and disappear without animation, while the JS Bootstrap component has an optional fade-and-slide effect. That effect will happen if the div.modal also has a .fade, and if this class is added to the HTML produced by component::Modal, it also works. Maybe there should be a property that allows using this behavior?

@isosphere
Copy link
Owner

I agree with your proposal; it sounds like it would be pretty easy to implement. A boolean property which would trigger adding the "fade" class to the set of classes added to the modal. If we aren't using the appendable classes pattern for this component, we certainly are elsewhere in the project.

If you make a PR for this I'll be happy to merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants