Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for newer Bootstrap versions #41

Open
pv42 opened this issue Feb 12, 2024 · 2 comments
Open

Support for newer Bootstrap versions #41

pv42 opened this issue Feb 12, 2024 · 2 comments

Comments

@pv42
Copy link

pv42 commented Feb 12, 2024

Bootstrap 5.3.0 supports color themes (e.g. dark mode), which i would like to use.

Just chanaging the version seems straigtforeward since there seem to be no breaking changes on the code side, but to preserve the access to the old version via the previous util::include APIs I suggest adding new includes for newer versions.
The simplest would be adding include_cdn_53() include_cdn_js_53() and include_inline_53().

But adding a Bootstrap version enum as argument to the include version would probably be a better solution.

@isosphere
Copy link
Owner

Theming is a valuable feature. If there are truly no breaking changes I would be in favour of simply migrating to 5.3.0 without backwards compatibility - it'll create less technical debt long-term; unless there is a good reason I am not considering to support multiple versions.

If bootstrap is faithfully using semantic versioning, it should be very painless, we'll just have more features on our todo list.

We'd want to review https://getbootstrap.com/docs/5.2/migration/ and https://getbootstrap.com/docs/5.3/migration/ before proceeding.

@pv42
Copy link
Author

pv42 commented Feb 12, 2024

There seem to be some changes to the style itself, for me the background of an active accordion header looks slightly darker for example but i can't quite find that mentioned in the change notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants