Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always build the processinfo temp dir #1061

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

isaacs
Copy link
Collaborator

@isaacs isaacs commented Apr 7, 2019

Always build the processinfo data directory (with index) in
${tmpdir}/processinfo. This more easily supports cases where the
processinfo index may be useful for later analysis, or generating the
process tree post hoc.

BREAKING CHANGE: this removes the --build-process-tree option, which
appeared in previous 14.0.0 prerelease versions.

Always build the processinfo data directory (with index) in
${tmpdir}/processinfo.  This more easily supports cases where the
processinfo index may be useful for later analysis, or generating the
process tree post hoc.

BREAKING CHANGE: this removes the --build-process-tree option, which
appeared in previous 14.0.0 prerelease versions.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 96.627% when pulling f49731b on isaacs:processinfo-always into e597c46 on istanbuljs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 96.627% when pulling f49731b on isaacs:processinfo-always into e597c46 on istanbuljs:master.

@coreyfarrell
Copy link
Member

All of my comments below the line assume nobody has objections to always building the processinfo files. I'm OK with it but want to give others a chance to speak. @bcoe @JaKXz @addaleax?


This will not be labeled as a breaking change. I plan to delete "add --build-process-tree feature" from the new features section of the changelog to prevent confusion. 14.0.0-alpha.0 was a non-tagged release so when we eventually do the final 14.0.0 release the changelog will be generated as if no pre-release versions were created (all changes between 13.3.0 and 14.0.0 will be listed as new to 14.0.0).

The cleanest way to handle this would be to revert #1028 in a separate commit to master and merge those changes into this PR. Then when standard-version generates the changelog it would see the revert and ignore #1028.

Further detail: we don't have strictness enabled in yargs, so nyc --build-process-tree will continue to work without error and the process tree will be build.

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me 👍 @coreyfarrell feel free to edit the CHANGELOG liberally, it's meant to be a convenience not the law.

@coreyfarrell coreyfarrell merged commit c213469 into istanbuljs:master Apr 9, 2019
@isaacs
Copy link
Collaborator Author

isaacs commented Apr 9, 2019

Very happy to be the one to help obliterate my previous contribution ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants