-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion about the behavior when initializing with an empty value #118
Comments
@istvan-ujjmeszaros One year has passed without any response. Is this project dead? |
@diesl good points under #106. I would be happy to improve the behavior, maybe by adding a new configuration parameter to set the behavior, defaulting to use the min value. But, on the other hand, I don't see a good use case to initialize the plugin with an empty value so I am just guessing what would be a suitable solution for everyone.
If we default to Also, I am not sure what to do when only one or the other (meaning the |
Just to note, the up and down buttons, the keyboard up/down arrows, and the mousewheel are all behaving consistent since the latest fixes are done (there are tests to make sure they all behave the same), so the behavior will be consistent across all methods of input. |
Thanks for picking this up again. Yes, I think it is a good idea to make this more flexible.
Not sure what exacltly you mean here.
Additionally, I would suggest the following:
I still think midpoint is fairly exotic and could be solved with a custom function, but of course this would be a breaking change again. Could be done with a major version number change though.
I case of midpoint, you can not compute it. Fall back to existing min or max. If both are not set, fall back to 0. |
I also wanted to note that this ticket originally was far more general and not focused on one particular setting:
|
I think that the settings and the events should be added to README.md too as this is quite obvious to update it when a new setting is being added. I will update the website too, but I am still thinking about what is the best way to do it (trying to come up with an automated way to populate the website with the latest version automagically - but I will update it manually in the next couple days). I have created #153 to be sure not to forget it. |
The documentation on the website is outdated. Could you please update it?
At least all Settings and Events should be documented, adding more examples is not absolutely necessary.
Also, the used version of the touchspin library should be updated, it uses v3.0.1 from 28 May 2014 ...
The text was updated successfully, but these errors were encountered: