Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the Windows display language is Russian, Alt + Q cannot be registered as a hotkey #56

Closed
itagagaki opened this issue Sep 20, 2023 · 5 comments
Assignees

Comments

@itagagaki
Copy link
Owner

itagagaki commented Sep 20, 2023

There is a detailed report in #52
I will look into this issue.

@itagagaki
Copy link
Owner Author

itagagaki commented Sep 20, 2023

I have found the cause. Failure to register Alt + Q as a hotkey because there is no key for Q in the Russian keyboard layout. I'm not sure, how do people with Russian keyboards type the alphabet?

@Lichtenshtein
Copy link

Lichtenshtein commented Sep 20, 2023

Failure to register Alt + Q as a hotkey

Not only Alt + Q... Any keyboard shortcut set for fragments or folders in the data tree does not work when launching Charu with (RUS) layout. I found a quick explanation for you, but it can hardly be particularly useful. See "The why" section:

microsoft/vscode#141761 (comment)

Also, setting both

HotKey=Alt+q
HotKey=Alt+й

as hotkey doesn't work. й=q key in russian layout.

In my opinion, there's a need for some kind of layer that registers only standard key codes and does not depend on the layout of the language in the system. Almost certainly there is already something exists and ready for this case.

@itagagaki
Copy link
Owner Author

Thank you for the info.
I have added a countermeasure. I'm a little unsure if it's the right fix, but I'll adopt it if it solves the problem for now.
I am concerned that there is no degradation, so could you please test it for a while?
Charu3_20230921.zip

@Lichtenshtein
Copy link

Lichtenshtein commented Sep 21, 2023

If i use my own settings file, inserting text from the data tree and any operations with selected text do not work. You need to go to Charu settings and reconfigure the hotkeys for copying and pasting, even if they are the same. Then everything works.

If make Charu recreate the settings file as if it was the first launch, then everything described above works as it should.

As for the non-functioning hotkeys when launching in regional language layout, it seems that now they work.

HotkeyScreener:
Alt + Q Charu3.exe (PID: 12492)

@itagagaki
Copy link
Owner Author

I have not been able to reproduce the problem of having to redo the key settings, so I am not sure what caused it on your end. I will see what happens after the next release.

@itagagaki itagagaki self-assigned this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants