Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions ephemeral registration option. #724

Closed
dacbd opened this issue Sep 21, 2021 · 3 comments · Fixed by #393 or #725
Closed

Github actions ephemeral registration option. #724

dacbd opened this issue Sep 21, 2021 · 3 comments · Fixed by #393 or #725
Assignees
Labels
enhancement New feature or request p1-important High priority technical-debt Refactoring, linting & tidying

Comments

@dacbd
Copy link
Contributor

dacbd commented Sep 21, 2021

Adding in github's new ephhemeral flag when running the config.sh could be of benefit.

For your consideration.

@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 21, 2021
@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request technical-debt Refactoring, linting & tidying labels Sep 21, 2021
@0x2b3bfa0 0x2b3bfa0 linked a pull request Sep 21, 2021 that will close this issue
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Sep 21, 2021

Thanks!

We support this functionality with cml-runner --single since #393, by making use of the undocumented --once option, which is fully somewhat equivalent to the newly introduced Runner.Listener configure --ephemeral option from actions/runner#660.

return spawn(resolve(workdir, 'run.sh') + (single ? ' --once' : ''), {

Even if they're fully equivalent, the latter is going to be deleted on October 2021 and we should use the new option instead.

@dacbd
Copy link
Contributor Author

dacbd commented Sep 21, 2021

Shouldn't this be a more robust option when handling any errors?

I didn't look too deep but their change (I hope)/a quick glance at the changes, it is more than a simple name swap, pretty sure it passes the flag when first reaching out to GitHub so that the GitHub side knows it's only good for one job?

https://github.com/actions/runner/blob/849d81a8cd745ce1217732275fa83107582beac5/src/Runner.Listener/Runner.cs#L469-L480

@0x2b3bfa0 0x2b3bfa0 added the p1-important High priority label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p1-important High priority technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants