Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: update pending target arg descriptions #1574

Closed
jorgeorpinel opened this issue Jul 13, 2020 · 2 comments
Closed

cmd: update pending target arg descriptions #1574

jorgeorpinel opened this issue Jul 13, 2020 · 2 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference good first issue Good for newcomers type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jul 13, 2020

Extracted from #1384 (comment)

Need to double check the following commands to see whether their targets support files/dirs ... repro, run, (un)freeze, remove, unprotect, update, and metrics/plots show

  • May imply core repo output string updates as well.
@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions good first issue Good for newcomers A: docs Area: user documentation (gatsby-theme-iterative) labels Jul 13, 2020
@imhardikj
Copy link
Contributor

@jorgeorpinel I checked the above commands with file/dirs:

  • repro: currently being worked on in repro cmdref updates #1861
  • For unfreeze, freeze, remove, when I tried them with files/dirs as targets this was the output:
    ERROR: failed to freeze/remove `foobar`- "Stage `foobar` not found inside `dvc.yaml` file"
  • update: directories were working when used with dvc update -R else same error as above
  • unprotect already excepts files/dirs
  • Similarly metrics show also accepts metrics files as targets.
  • run: doesn't have targets argument

Does this require updating targets description in the update command or rather just the -R option desc.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Oct 28, 2020

Similarly metrics show also accepts metrics files as targets.

What about plots show? I'll look into that. UPDATE: See iterative/dvc#4799

Does this require updating targets description in the update command

No, that cmd ref seems to have complete info about -R and dir targets already.

Looks like no major changes are needed...

@iesahin iesahin added the C: ref Content of /doc/*-reference label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference good first issue Good for newcomers type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

3 participants