Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: move explanations from cmd ref to guide #3818

Closed
5 of 7 tasks
dberenbaum opened this issue Jul 27, 2022 · 6 comments
Closed
5 of 7 tasks

plots: move explanations from cmd ref to guide #3818

dberenbaum opened this issue Jul 27, 2022 · 6 comments
Assignees
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference

Comments

@dberenbaum
Copy link
Collaborator

dberenbaum commented Jul 27, 2022

My only larger concern here is that there's too much info. in the command reference. We should move a good part (probably most) of the new content to the dvc.yaml schema "guide". For more specific ideas see the following comments:

Other less important stuff:


Originally posted by @jorgeorpinel in #3691 (review)

@jorgeorpinel jorgeorpinel changed the title plots: move info from cmd ref to guide plots: move explanations from cmd ref to guide Jul 31, 2022
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference labels Jul 31, 2022
@dberenbaum
Copy link
Collaborator Author

dberenbaum commented Aug 5, 2022

  • ... ideally we would dissolve the examples into the explanations themselves then, as suggested here.
  • Unrelated but should we rename this Custom Vega templates since there's a Custom HTML templates H2 right after this?
  • Separate "guide" info from "ref" info.

@jorgeorpinel
Copy link
Contributor

Sorry to back pedal here but we may have gone too far in removing everything from the plots ref 😅 . Maybe we need a mixed approach like in #3414 (comment). Hopefully after we figure that one out (re params) we'll have a solid framework.

@dberenbaum
Copy link
Collaborator Author

@jorgeorpinel Do you think there's anything left to do here?

@jorgeorpinel
Copy link
Contributor

  • Think through plots ref examples

The cmd ref examples could use some grouping and possibly renaming, esp. in https://dvc.org/doc/command-reference/plots/show which has too many IMO.

  • rename this Custom Vega templates since there's a Custom HTML templates

Still an open question (which also relates to .../plots/show#custom-html-templates)

  • Separate "guide" info from "ref" info

I think we did that for all refs except maybe https://dvc.org/doc/command-reference/plots/templates which still feels too heavy/deep. Should be self-containted, yes, but brief. Longer explanations, technical details, even some formal definition may be better in the guide.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 22, 2022

p.s. may also want to reconsider the plots part of #2572 . Do we need separate plots-related guides (or perhaps file references) besides what's now inside Exp Mgmt?

@dberenbaum
Copy link
Collaborator Author

Don't think we have time to prioritize the tail of tasks here.

@dberenbaum dberenbaum closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference
Projects
None yet
Development

No branches or pull requests

3 participants