Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test/remotes.py by merging inside remote classes #2878

Closed
skshetry opened this issue Dec 1, 2019 · 3 comments · Fixed by #3149
Closed

Refactor test/remotes.py by merging inside remote classes #2878

skshetry opened this issue Dec 1, 2019 · 3 comments · Fixed by #3149
Assignees
@skshetry
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring

Comments

@skshetry
Copy link
Member

skshetry commented Dec 1, 2019

#2853 was just merged, which refactored different helper functions into test/remotes.py. There are different remote classes (such as S3, Azure, etc) and functions such as get_aws_url()/get_gcp_url.

It'd be good to merge them inside their respective remote classes. :)
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Dec 1, 2019
@skshetry
Copy link
Member Author

skshetry commented Dec 1, 2019

I have started working on it. :)

@skshetry skshetry mentioned this issue Dec 1, 2019
Merged
11 tasks
@efiop efiop added the refactoring Factoring and re-factoring label Dec 1, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Dec 1, 2019
@efiop efiop added enhancement Enhances DVC triage Needs to be triaged labels Dec 1, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Dec 1, 2019
@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Dec 1, 2019
@weekly-digest weekly-digest bot mentioned this issue Dec 8, 2019
Closed
@skshetry
Copy link
Member Author

skshetry commented Dec 17, 2019 •
edited
Loading

I haven't been able to continue working on this. I'll be able to continue on this only after Christmas. Sorry for not being quick on this. 🙂

@efiop
Copy link
Contributor

efiop commented Dec 17, 2019

@skshetry No worries 🙂 Thanks for the heads up!

This was referenced Jan 4, 2020
Merged
Merged
Merged
Merged
This was referenced Jan 13, 2020
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skshetry skshetry

Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: use helper remotes in external repro skshetry/dvc
2 participants
@efiop @skshetry