Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0: final release #4072

Closed
casperdcl opened this issue Jun 19, 2020 · 11 comments
Closed

v0: final release #4072

casperdcl opened this issue Jun 19, 2020 · 11 comments
Labels
awaiting response we are waiting for your reply, please respond! :) bug Did we break something? build Issues/features related to building dvc install packages. testing Related to the tests and the testing infrastructure

Comments

@casperdcl
Copy link
Contributor

There's a failing SSH test on the 0.94.0-dev branch: https://travis-ci.com/github/iterative/dvc/jobs/348781315#L7880

Would be great to fix it so that a new (final) v0 release can be made to address #3872.
@casperdcl casperdcl added bug Did we break something? testing Related to the tests and the testing infrastructure build Issues/features related to building dvc install packages. labels Jun 19, 2020
@efiop
Copy link
Contributor

efiop commented Jun 19, 2020

@casperdcl Not worth spending time on it.

@efiop
Copy link
Contributor

efiop commented Jun 19, 2020

You can release even with failing tests, if you restart the deploy jobs on travis (just click restart there)

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Jun 19, 2020
@casperdcl
Copy link
Contributor Author

last time I checked that wasn't possible. Admittedly a very long time ago.

So in that case can you create a new v0 release? That would start the clock for putting it to bed...

@skshetry
Copy link
Member

@casperdcl, why do we need to release a v0? Does snap not allow these kind of changes?

@casperdcl
Copy link
Contributor Author

casperdcl commented Jun 19, 2020 •
edited
Loading

I mean tagging & releasing dvc==0.94.1 or similar from the current https://github.com/iterative/dvc/tree/0.94.0-dev

@efiop
Copy link
Contributor

efiop commented Jun 19, 2020

@casperdcl Will do in a sec.

@efiop
Copy link
Contributor

efiop commented Jun 19, 2020 •
edited
Loading

@casperdcl https://travis-ci.com/github/iterative/dvc/builds/172217010 , waiting for it to finish.

@casperdcl casperdcl changed the title tests: SSH: fix v0 v0: final release Jun 19, 2020
@efiop
Copy link
Contributor

efiop commented Jun 19, 2020

@casperdcl Looks like it is done. Closing for now. Let me know if something is off about the snap.

@efiop efiop closed this as completed Jun 19, 2020
@casperdcl
Copy link
Contributor Author

image

Running

  • snap refresh dvc --channel=v0/stable, or
  • snap refresh dvc --channel=latest/beta

makes the message go away.

@efiop
Copy link
Contributor

efiop commented Jun 19, 2020

@casperdcl Amazing stuff! Thank you! 🙏

@casperdcl
Copy link
Contributor Author

great; there are a couple of quick items in #3872 which we'll be able to check off in a month and then never mention this again :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting response we are waiting for your reply, please respond! :) bug Did we break something? build Issues/features related to building dvc install packages. testing Related to the tests and the testing infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@efiop @casperdcl @skshetry