Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invidio.us embed doesn't allow clicking through to Invidio.us when Google domains blocked #177

Closed
ajvsol opened this issue Sep 21, 2018 · 12 comments

Comments

@ajvsol
Copy link

ajvsol commented Sep 21, 2018

If you block youtube.com and googlevideo.com domains then you get just a picture reading "The media could not be loaded, either because the server or network failed or because the format is not supported."

There's no way to click through to watch the video on Invidio.us and right-clicking the video doesn't bring up any additional options either.

@omarroth
Copy link
Contributor

omarroth commented Sep 22, 2018

Hi! Currently Invidious pulls videos from googlevideo.com. The reason why you're seeing this error is because all the sources for the video are being blocked. There's some more information provided here, but to paraphrase it's more bandwidth-intensive for the site to proxy videos. With #34 the videos will be proxied through Invidious so this won't be an issue, but unfortunately both the site and the embeds currently use googlevideo.com links.

@omarroth omarroth reopened this Sep 22, 2018
@Jtasiu
Copy link

Jtasiu commented Sep 23, 2018

With #34 the videos will be proxied through Invidious so this won't be an issue

That sound amazing @omarroth! Is it really possible without too much bandwidth costs?

@omarroth
Copy link
Contributor

Well, that remains to be seen. Currently thumbnails don't add that much extra cost, but they're much smaller. I think in the coming week I'll probably push experimental 1080p to registered users, and then site-wide depending on bandwidth usage.

@dimqua
Copy link
Contributor

dimqua commented Sep 23, 2018

Is it REALLY necessary to proxy 1080p videos to have a support of them? After all, youtube-dl doesn't proxy anything.

@omarroth
Copy link
Contributor

There's more info here, but to paraphrase: because of the way 1080p+ videos are packaged, it is very preferable to use something like DASH to combine the audio and video streams. DASH has some other technical requirements that can only be met by proxying the video files. Sorry for the somewhat round-about answer, but I have looked into this quite a bit and I think that proxying files is the solution in this case. Obviously the increased bandwidth usage is not ideal.

The reason youtube-dl doesn't proxy anything because it has full control over the requests it makes and how the files are combined. When in the browser, you have to work with/around CORS, which makes it difficult to directly request files from googlevideo.com (when they are provided seperately).

@PrestonN provides a good explanation here.
There's also an explanation by @cloudrac3r here.

Short answer is yes, it is necessary. :)

@dimqua
Copy link
Contributor

dimqua commented Sep 23, 2018

Hmm, doesn't linked @cloudrac3r's comment means that he already found a some sort of solution for this issue?

@omarroth
Copy link
Contributor

Yes, @cloudrac3r's solution is to sync the audio and video manually. That is also the solution that @PrestonN considers in his linked comment as well. The problem with syncing it manually is that it gets very messy very quickly. Keeping audio and video in sync when quality changes, speed changes, among other things makes it difficult to pull off.

@cloudrac3r
Copy link
Collaborator

I haven't found a situation where I haven't been able to play 1080p+, and more often that not it works without an issue, but there are times when I have to fiddle with the pause button to hear sound or to get it to synchronise properly.

Proxying videos on Invidious was already a requested feature — using that to play DASH videos the proper way is obviously the best move.

@omarroth
Copy link
Contributor

You can currently view videos without connecting Google domains by enabling Proxy videos? in your preferences or by setting default quality to dash, so I'm going to close this.

@ajvsol
Copy link
Author

ajvsol commented Mar 21, 2019

This doesn't appear to work for embedded videos (e.g. using the Invidious Embed extension) without googlevideo.com also being allowed. Videos viewed through invidio.us directly however seem to be proxied fully.

@omarroth
Copy link
Contributor

You may have to clarify what you mean. User preferences are not used when watching an embedded video, but adding local=true as I mentioned appears to work as expected, example: https://invidio.us/embed/aqz-KE-bpKQ?local=true .

I'm not opposed to using user preferences in embeds. I'd recommend opening a new issue for that to further discussion.

@ajvsol
Copy link
Author

ajvsol commented Mar 25, 2019

Ah I thought it was still related to the original issue since embeds still don't work fully but I can open a new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants