Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment on parameter names #59

Open
BaptisteCecconi opened this issue Apr 4, 2024 · 2 comments
Open

Comment on parameter names #59

BaptisteCecconi opened this issue Apr 4, 2024 · 2 comments

Comments

@BaptisteCecconi
Copy link
Contributor

I have issues with the names of the parameters, some of which are not explicit (or could be misleading, without reading the documentation). Mostly it is:

  • instrument_ant_number: this is intended to refer to the number of antenna, where one can expect to get the number of the antenna in use. I suggest to replace with instrument_ant_count, which makes it fully explicit.
  • instrument_feed: this is intended to refer to the number of antenna feed, whereas I would expect a antenna feed name with such a name. May be replace by instrument_feed_count?
@kettenis
Copy link
Collaborator

kettenis commented Apr 4, 2024

I think most, if not all, of the instrument_xxx parameters should be removed from the standard. These parameters are mostly meaningless unless you're doing an instrument-specific query.

@alle-ira
Copy link
Member

alle-ira commented Apr 4, 2024

We agree that instrument_xxx would be used for more advanced discovery. For instance instrument_ant_count could be of interest in the case of split array observations, when the user wants to select only those observations involving at least a given number of stations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants