-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pooling Layers #2
Comments
Thanks for your helpful observations! Regarding your second point, I believe this is only an issue with the latest PyPI release. A unit test has been added for this demo in master. The PyPI release will be updated soon, thanks for pointing this out :) Regarding the issue with jupyter notebook, does the issue appear simply when calling |
Could you also please create separate issues for the "Quick Start" issue and the Jupyter notebook issue? I can then close these issues individually once they have been resolved. Thanks! |
Done! Regarding the issue with jupyter notebook, it's my fault - I didn't add 'ivy.unset_framework()' after running in PyTorch, so something went wrong when running in tensorflow. Sorry for that! |
resolving issues ivy-llc#2
* inital changes * changes * changes * changes * changes * changes * fix formatting for test_modules * changes * fix some formatting errors for our new tests * added docstrings for most but not all methods * add basic docstring outlines for all functions in module.py, need descriptions for functions, arguments and retursn * docstring add #1 (Need discussion) and (TODO) flags added for further discussion * add docstring #2 * add separation of positional-only arguments and keyword-only arguments * fix syntax error of module.py * changes and fixes * fixes * lint fixes * changes * changes * changes * changes; * conftest update deadline * changes made as requested * changes: Co-authored-by: Rishabh Kumar <[email protected]> Co-authored-by: Daniel4078 <[email protected]> Co-authored-by: Zilin Xiao <[email protected]>
* replace calls with fw * removed call * added param * changed dev_str to device * replaced test calls to fw * handle positional and keyword args * handle positional and keyword args * changed fourier_encode * undo change
Would be better to be able to add pooling in the layers, like MaxPool2D.
The text was updated successfully, but these errors were encountered: