Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Duplicate Code into Helper Function in ivy\func_wrapper.py #26573

Closed
Sai-Suraj-27 opened this issue Oct 4, 2023 · 0 comments · Fixed by #26572
Closed

Extract Duplicate Code into Helper Function in ivy\func_wrapper.py #26573

Sai-Suraj-27 opened this issue Oct 4, 2023 · 0 comments · Fixed by #26572

Comments

@Sai-Suraj-27
Copy link
Contributor

I identified duplicate sections of code in the following functions:
https://github.com/unifyai/ivy/blob/2bfb19a2ca3b277e95cba987353aa349ef28015e/ivy/func_wrapper.py#L94
https://github.com/unifyai/ivy/blob/2bfb19a2ca3b277e95cba987353aa349ef28015e/ivy/func_wrapper.py#L137

I think it will be good if we can extract these into their own method/function to increase the readability and decrease the amount of duplicate/repeating code in the file. This can simplify the code and reduce redundancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant