Dropout 2D function and Test in Paddle #17477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
Paddle Frontend
|
Hi @HaiderSultanArc please also make sure that the formatting test passes or I cannot merge the PR. You can check the logs here on github or locally to see what went wrong! |
|
@DragosStoican I fixed the formatting. Let me know if any other changes are required. |
| @handle_frontend_test( | ||
| fn_tree="paddle.nn.functional.common.dropout2d", | ||
| d_type_and_x=helpers.dtype_and_values( | ||
| available_dtypes=helpers.get_dtypes("float"), |
There was a problem hiding this comment.
We should be ideally testing for all valid dtypes, and not only a subset.
|
When testing the function, we should ideally test for all valid dtypes, not only a subset. Can you use the key "valid" when generating dtypes and making sure the test is still passing? I added a comment on that line to help you understand what I'm referring to :) |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #17475