Added bilinear function in ivy.frontend.paddle.nn.functional.common.py #21371

MuhammadTalha-10 · 2023-08-06T13:21:04Z

github-actions · 2023-08-06T13:21:20Z

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

ivy-leaves · 2023-08-06T13:30:02Z

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

AryanSharma21

Hello, @MuhammadTalha-10 ,Kindly add the close #issue_number in the PR description, so that the pull request gets linked to the issue that you have just created. Doing this, will automatically close the issue as completed when the pull request gets merged.

Also, while you have added the implementation for the function, you should also add the test function in the corresponding test file.
Thanks

MuhammadTalha-10 · 2023-08-06T15:45:38Z

Also, while you have added the implementation for the function, you should also add the test function in the corresponding test file. Thanks

In ivy_test directory?

AryanSharma21 · 2023-08-06T16:45:01Z

Yes the description is correct as the issue is now linked , and you should implement test in the ivy test directory. please find the correct frontend test file.

MuhammadTalha-10 · 2023-08-06T18:02:07Z

Yes the description is correct as the issue is now linked , and you should implement test in the ivy test directory. please find the correct frontend test file.

I will do it as soon as possible thank you for guidance.

MuhammadTalha-10 · 2023-08-09T07:06:01Z

Yes the description is correct as the issue is now linked , and you should implement test in the ivy test directory. please find the correct frontend test file.

I have committed the final changes

AryanSharma21 · 2023-08-09T14:26:05Z

@MuhammadTalha-10 , looked at the test logs, It seems that there is some issue with the test configuration.

E fixture 'dtype_x_weight_bias' not found

please recheck it once and do try to run the test locally as well.
Besides , we can wait for review from maintainer @aparajith21 , to understand better

MuhammadTalha-10 · 2023-08-09T14:38:49Z

@MuhammadTalha-10 , looked at the test logs, It seems that there is some issue with the test configuration.

E fixture 'dtype_x_weight_bias' not found

please recheck it once and do try to run the test locally as well.
Besides , we can wait for review from maintainer @aparajith21 , to understand better

Sure, I will try to fix this issue

MuhammadTalha-10 · 2023-08-10T13:38:59Z

@MuhammadTalha-10 , looked at the test logs, It seems that there is some issue with the test configuration.

E fixture 'dtype_x_weight_bias' not found

please recheck it once and do try to run the test locally as well. Besides , we can wait for review from maintainer @aparajith21 , to understand better

I tested it locally after making some changes and no error occurred there was just a warning "WARNING:root:This function includes the mixed partial function 'ivy.linear'. Please note that the returned data types may not be exhaustive. Please check the dtypes of ivy.linear for more details"

aparajith21 · 2023-08-11T04:19:33Z

ivy_tests/test_ivy/test_frontends/test_paddle/test_nn/test_functional/test_common.py

+    frontend,
+    test_flags,
+):
+    dtype, x1, x2, weight, bias = dtype_x_weight_bias


Please fetch the support dtypes for this test instead of reusing the earlier one for linear using the handle_frontend_test decorator similar to other tests to configure the test correctly!

aparajith21 · 2023-08-11T04:20:12Z

Thanks for contributing, sorry just checking! Could you comment add_frontend_checklist and tick off the items there please before I review!

MuhammadTalha-10 · 2023-08-14T13:35:48Z

Can you help me with these conflicts? I am committing changes in my own branch but there are conflicting files and I am unable to figure this out why is this happening

into bilinear#21366

aparajith21 · 2023-08-16T15:51:09Z

ivy/functional/frontends/paddle/nn/functional/common.py

@@ -113,5 +113,14 @@ def linear(x, weight, bias=None, name=None):

 @to_ivy_arrays_and_back
 @with_supported_dtypes({"2.5.1 and below": ("float32", "float64")}, "paddle")
-def dropout3d(x, p=0.5, training=True, data_format="NCDHW", name=None):
-    return ivy.dropout3d(x, p, training=training, data_format=data_format)


Please don't remove any existing code to add yours!

aparajith21 · 2023-08-16T15:51:36Z

ivy_tests/test_ivy/test_frontends/test_paddle/test_nn/test_functional/test_common.py

 @handle_frontend_test(
-    fn_tree="paddle.nn.functional.common.dropout3d",


Again, please don't remove code to add tests!

aparajith21 · 2023-08-16T15:52:38Z

Can you help me with these conflicts? I am committing changes in my own branch but there are conflicting files and I am unable to figure this out why is this happening

Try pulling a fresh fork of ivy and then adding your changes, currently you seem to have removed a few lines of code that were present, please revert these, and can then review once you request. Thanks for contributing

MuhammadTalha-10 · 2023-08-16T16:14:34Z

I will try that, thanks!

Added bilinear function in ivy.frontend.paddle.nn.functional.common.py

4164915

ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 6, 2023

MuhammadTalha-10 changed the title ~~Added bilinear function in ivy.frontend.paddle.nn.functional.common.py~~ https://github.com/unifyai/ivy/issues/21366 Aug 6, 2023

ivy-seed assigned aparajith21 Aug 6, 2023

AryanSharma21 reviewed Aug 6, 2023

View reviewed changes

MuhammadTalha-10 changed the title ~~https://github.com/unifyai/ivy/issues/21366~~ https://github.com/unifyai/ivy/issues/21366. close #21366 Aug 6, 2023

MuhammadTalha-10 changed the title ~~https://github.com/unifyai/ivy/issues/21366. close #21366~~ Added bilinear function in ivy.frontend.paddle.nn.functional.common.py Aug 6, 2023

unknown added 3 commits August 8, 2023 11:47

Added test function for bilinear in ivy_test

55f46f3

made some changes in bilinear function and added test function

0c78491

made some changes in bilinear function and added test function

20745d4

aparajith21 reviewed Aug 11, 2023

View reviewed changes

unknown added 5 commits August 11, 2023 17:37

added test handler

708a6c6

just testing

c235a33

just testing

e0b2e35

made changes just to testing

ede8c34

test

2357f67

unknown and others added 3 commits August 14, 2023 18:44

made changes just for testing

bee6cc9

Merge branch 'main' into bilinear#21366

921a962

-

15c635c

unknown added 2 commits August 14, 2023 19:35

Merge branch 'bilinear#21366' of https://github.com/MuhammadTalha-10/ivy

1f6d7cb

into bilinear#21366

none

3b8f78b

aparajith21 reviewed Aug 16, 2023

View reviewed changes

ivy-leaves unassigned aparajith21 Dec 23, 2023

ivy-seed assigned Ishticode Dec 23, 2023

NripeshN closed this Dec 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added bilinear function in ivy.frontend.paddle.nn.functional.common.py #21371

Added bilinear function in ivy.frontend.paddle.nn.functional.common.py #21371

MuhammadTalha-10 commented Aug 6, 2023 •

edited

Loading

github-actions bot commented Aug 6, 2023

ivy-leaves commented Aug 6, 2023

AryanSharma21 left a comment

MuhammadTalha-10 commented Aug 6, 2023 •

edited

Loading

AryanSharma21 commented Aug 6, 2023

MuhammadTalha-10 commented Aug 6, 2023

MuhammadTalha-10 commented Aug 9, 2023

AryanSharma21 commented Aug 9, 2023

MuhammadTalha-10 commented Aug 9, 2023

MuhammadTalha-10 commented Aug 10, 2023

aparajith21 Aug 11, 2023 •

edited

Loading

aparajith21 commented Aug 11, 2023

MuhammadTalha-10 commented Aug 14, 2023

aparajith21 Aug 16, 2023

aparajith21 Aug 16, 2023

aparajith21 commented Aug 16, 2023 •

edited

Loading

MuhammadTalha-10 commented Aug 16, 2023

		@handle_frontend_test(
		fn_tree="paddle.nn.functional.common.dropout3d",

Added bilinear function in ivy.frontend.paddle.nn.functional.common.py #21371

Added bilinear function in ivy.frontend.paddle.nn.functional.common.py #21371

Conversation

MuhammadTalha-10 commented Aug 6, 2023 • edited Loading

github-actions bot commented Aug 6, 2023

ivy-leaves commented Aug 6, 2023

AryanSharma21 left a comment

Choose a reason for hiding this comment

MuhammadTalha-10 commented Aug 6, 2023 • edited Loading

AryanSharma21 commented Aug 6, 2023

MuhammadTalha-10 commented Aug 6, 2023

MuhammadTalha-10 commented Aug 9, 2023

AryanSharma21 commented Aug 9, 2023

MuhammadTalha-10 commented Aug 9, 2023

MuhammadTalha-10 commented Aug 10, 2023

aparajith21 Aug 11, 2023 • edited Loading

Choose a reason for hiding this comment

aparajith21 commented Aug 11, 2023

MuhammadTalha-10 commented Aug 14, 2023

aparajith21 Aug 16, 2023

Choose a reason for hiding this comment

aparajith21 Aug 16, 2023

Choose a reason for hiding this comment

aparajith21 commented Aug 16, 2023 • edited Loading

MuhammadTalha-10 commented Aug 16, 2023

MuhammadTalha-10 commented Aug 6, 2023 •

edited

Loading

MuhammadTalha-10 commented Aug 6, 2023 •

edited

Loading

aparajith21 Aug 11, 2023 •

edited

Loading

aparajith21 commented Aug 16, 2023 •

edited

Loading