Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor torch frontend avg pooling functions #21812

Merged
merged 11 commits into from
Aug 17, 2023
Merged

Refactor torch frontend avg pooling functions #21812

merged 11 commits into from
Aug 17, 2023

Conversation

mohame54
Copy link
Contributor

refactored avg pooling frontend functions and thier tests

@mohame54 mohame54 requested a review from AnnaTz August 13, 2023 19:05
@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 13, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@mohame54
Copy link
Contributor Author

#21814
this a link to the other PR which is related to the refactoring task

@mohame54 mohame54 requested a review from AnnaTz August 15, 2023 16:27
@AnnaTz AnnaTz changed the title Refactor torch and paddle frontend pooling functions Refactor torch frontend avg pooling functions Aug 16, 2023
@mohame54 mohame54 requested a review from AnnaTz August 16, 2023 16:09
AnnaTz
AnnaTz approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@AnnaTz AnnaTz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, we can merge this then. Thanks!

@AnnaTz AnnaTz merged commit 15975ab into ivy-llc:main Aug 17, 2023
110 of 133 checks passed
sushmanthreddy pushed a commit to sushmanthreddy/ivy that referenced this pull request Aug 17, 2023
@mohame54 @sushmanthreddy
Refactor torch frontend avg pooling functions (ivy-llc#21812)
6394e8a 
Co-authored-by: @AnnaTz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaTz AnnaTz AnnaTz approved these changes

@Aarsh2001 Aarsh2001 Awaiting requested review from Aarsh2001

@fnhirwa fnhirwa Awaiting requested review from fnhirwa

Assignees

@fnhirwa fnhirwa

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohame54 @ivy-leaves @AnnaTz @fnhirwa