Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve_triangular #21961

Closed
wants to merge 2 commits into from
Closed

solve_triangular #21961

wants to merge 2 commits into from

Conversation

Tufty62
Copy link

@Tufty62 Tufty62 commented Aug 15, 2023

Hi, this is my pull request for issue #7479 (adding linear algebra operations to Pytorch frontend). I added the solve_triangular function. It'd be great if you could take a look!

Thank you!

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@Tufty62 Tufty62 mentioned this pull request Aug 15, 2023
1 task
@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 15, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@ZoeCD
Copy link
Contributor

ZoeCD commented Aug 18, 2023

Hello!
This function has already been taken and is being worked on by another contributor. I'm afraid I'll have to close this pull request. I recommend checking the available functions and creating an issue right away before someone else takes it.
If you have any questions, please let me know!

@ZoeCD ZoeCD closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants