Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the lu_solve function #21981

Closed
wants to merge 3 commits into from
Closed

Added the lu_solve function #21981

wants to merge 3 commits into from

Conversation

TomiwaPhilip
Copy link
Contributor

Close #21980

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Aug 16, 2023
@TomiwaPhilip
Copy link
Contributor Author

@zaeemansari70 @edaehn @thecoder12 @ivy-leaves

Please I need to you review this PR now. This is because I should be in the next internship hiring stage by now. I am already 1 week close to my starting date and my PR has not been accepted yet. Please review this PR and tell me changes to effect immediately you are reading this!

zaeemansari70
zaeemansari70 suggested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@zaeemansari70 zaeemansari70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requested some changes,
Thanks!

ivy/functional/frontends/tensorflow/linalg.py Outdated

@to_ivy_arrays_and_back
def lu_solve(lower_upper, perm, rhs, validate_args=False, name=None):
return ivy.solve(lower_upper, perm, rhs, validate_args=False, name=None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ivy.solve() takes on 2 arguments, also I'd suggest you should read the docstring on how does this function work.
I'd suggest you implement this compositionally for now. If you don't know what compositionally means I'd refer you to our deep dive in the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any information like this in the deep dive doc, please. Can you help?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaeemansari70 Please check what I just did!

ivy_tests/test_ivy/test_frontends/test_tensorflow/test_linalg.py Outdated
test_flags=test_flags,
fn_tree=fn_tree,
on_device=on_device,
input=input[0],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not expecting input as an argument according to the function definintion.
You have to handle lower_upper, perm, rhs, validate_args for it to work

zaeemansari70
zaeemansari70 suggested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@zaeemansari70 zaeemansari70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes. 🙂

ivy/functional/frontends/tensorflow/linalg.py

@to_ivy_arrays_and_back
def lu_solve(lower_upper, rhs): # ToDO
return ivy.solve(lower_upper, rhs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go, this might help you 🙂 https://unify.ai/docs/ivy/docs/functional/ivy/linear_algebra/ivy.functional.ivy.linear_algebra.solve.html#solve

ivy/functional/frontends/tensorflow/linalg.py


@to_ivy_arrays_and_back
def lu_solve(lower_upper, rhs): # ToDO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function definition should be all the arguments present here https://www.tensorflow.org/api_docs/python/tf/linalg/lu_solve

@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@zaeemansari70
Copy link
Contributor

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaeemansari70 zaeemansari70 zaeemansari70 requested changes

Assignees

@zaeemansari70 zaeemansari70

Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lu_solve
3 participants
@TomiwaPhilip @ivy-leaves @zaeemansari70