Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sigmoid_focal_loss to paddle frontend and refactored mse_loss in paddle frontend #22585

Merged
merged 11 commits into from
Sep 1, 2023
Merged

added sigmoid_focal_loss to paddle frontend and refactored mse_loss in paddle frontend #22585

merged 11 commits into from
Sep 1, 2023

Conversation

zeus2x7
Copy link
Contributor

@zeus2x7 zeus2x7 commented Aug 25, 2023 •
edited
Loading

close #19759
subtask #15053
Refactored mse_loss in paddle frontend to pass all the tests

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 25, 2023
@zeus2x7
Copy link
Contributor Author

zeus2x7 commented Aug 29, 2023

Hi @MuhammedAshraf2020 can you please review the pr?

@zeus2x7 zeus2x7 changed the title added sigmoid_focal_loss and square_error_cost to paddle frontend and refactored mse_loss in paddle frontend added sigmoid_focal_loss to paddle frontend and refactored mse_loss in paddle frontend Aug 30, 2023
@zeus2x7
Copy link
Contributor Author

zeus2x7 commented Aug 31, 2023

@MuhammedAshraf2020 it would be really helpful if you could review the pr

@MuhammedAshraf2020
Copy link
Contributor

Hi @zeus2x7
Thanks for the PR. There seems to be a few small issues that I pointed out below.

@zeus2x7
Copy link
Contributor Author

zeus2x7 commented Sep 1, 2023

hi @MuhammedAshraf2020 can you please review it now?

@MuhammedAshraf2020
Copy link
Contributor

Great, Thanks

@MuhammedAshraf2020 MuhammedAshraf2020 merged commit b305cf4 into ivy-llc:main Sep 1, 2023
115 of 133 checks passed
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
@zeus2x7 @druvdub
added sigmoid_focal_loss to paddle frontend and refactored mse_loss i…
dd3c6eb 
…n paddle frontend (ivy-llc#22585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuhammedAshraf2020 MuhammedAshraf2020 MuhammedAshraf2020 approved these changes

Assignees

@MuhammedAshraf2020 MuhammedAshraf2020

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sigmoid_focal_loss
4 participants
@zeus2x7 @MuhammedAshraf2020 @sagewhocodes @ivy-leaves