fix: mode #23325
fix: mode #23325
Conversation
|
Thanks for contributing to Ivy! 😊👏 |
|
Please review |
ivy-leaves
added
the
Paddle Frontend
|
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
|
close #23325 |
|
Can you kindly link the issue and the paddle doc link for the function that you are trying to implement. I can not find it |
|
|
||
| #crrop | ||
| # Load an image (you'll need to have an image file) | ||
| image_path = "input_image.jpg" # Replace with your image file path |
There was a problem hiding this comment.
Please remove this code. This is not relevant.
There was a problem hiding this comment.
I have been trying to link the issue and the paddle doc bit i haven't been able to.
Can you guide me through it, please?
There was a problem hiding this comment.
Sure, I will remove the codes
There was a problem hiding this comment.
You have to implement the frontend as explained here https://unify.ai/docs/ivy/overview/contributing/open_tasks.html#frontend-apis
mode
Outdated
| @@ -0,0 +1,31 @@ | |||
| import paddle | |||
There was a problem hiding this comment.
This is not how you how implement a function. Can you kindly share the todo list
There was a problem hiding this comment.
You have to implement paddle.mode(x, axis=- 1, keepdim=False, name=None) function in the paddle frontend. Which will call the ivy.mode function. But before that you have to make sure the ivy.mode function is implemented in the ivy api. Likewise, you have to also make sure the mode function is implemented in all of the backends. If it is not, you can work on implementing that. Check https://unify.ai/docs/ivy/overview/contributing/open_tasks.html#ivy-experimental-api
|
I have been unable to link the issue to the development, can you help me with it? |
| @@ -87,6 +87,14 @@ def sort(x, /, *, axis=-1, descending=False, name=None): | |||
| def topk(x, k, axis=None, largest=True, sorted=True, name=None): | |||
| return ivy.top_k(x, k, axis=axis, largest=largest, sorted=sorted) | |||
|
|
|||
| #mode | |||
| @with_supported_dtypes( | |||
There was a problem hiding this comment.
You also have to implement its test function
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
|
Hello, are you still working on this? |
Close #23325
Related Issue
Close #23325
Checklist
Socials: