From 0bea022cd69d236a984ce944423ed7e92ea468db Mon Sep 17 00:00:00 2001 From: Jay Choy <91728831+ZJay07@users.noreply.github.com> Date: Mon, 11 Mar 2024 11:09:19 +0000 Subject: [PATCH 1/2] fixed tf.reduce_prod --- .../test_ivy/test_frontends/test_tensorflow/test_math.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py b/ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py index 3d14053f47e38..4686d006f3766 100644 --- a/ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py +++ b/ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py @@ -2432,6 +2432,8 @@ def test_tensorflow_reduce_min( fn_tree="tensorflow.math.reduce_prod", dtype_and_x=helpers.dtype_and_values( available_dtypes=helpers.get_dtypes("numeric"), + min_value=-5, + max_value=5, ), test_with_out=st.just(False), ) @@ -2453,6 +2455,8 @@ def test_tensorflow_reduce_prod( fn_tree=fn_tree, on_device=on_device, input_tensor=x[0], + rtol=1e-02, + atol=1e-02, ) From 6c3a2184d12f4f08e9be95689d329b4b96307c39 Mon Sep 17 00:00:00 2001 From: Jay Choy <91728831+ZJay07@users.noreply.github.com> Date: Sun, 31 Mar 2024 12:51:01 +0000 Subject: [PATCH 2/2] introduced safety factors --- .../test_ivy/test_frontends/test_tensorflow/test_math.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py b/ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py index 4686d006f3766..3c1e26a9063a0 100644 --- a/ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py +++ b/ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py @@ -2432,8 +2432,9 @@ def test_tensorflow_reduce_min( fn_tree="tensorflow.math.reduce_prod", dtype_and_x=helpers.dtype_and_values( available_dtypes=helpers.get_dtypes("numeric"), - min_value=-5, - max_value=5, + large_abs_safety_factor=24, + small_abs_safety_factor=24, + safety_factor_scale="log", ), test_with_out=st.just(False), ) @@ -2455,8 +2456,6 @@ def test_tensorflow_reduce_prod( fn_tree=fn_tree, on_device=on_device, input_tensor=x[0], - rtol=1e-02, - atol=1e-02, )