Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cholesky to torch frontend #7694

Merged
merged 5 commits into from
Dec 15, 2022
Merged

Added cholesky to torch frontend #7694

merged 5 commits into from
Dec 15, 2022

Conversation

theRealBird
Copy link
Contributor

Added cholesky to PyTorch frontend and its tests (which use a positive definite square symmetric matrix)

Issue cholesky #7595
To-Do List Reference #7479

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Dec 8, 2022
@theRealBird theRealBird changed the title add cholesky to torch frontend Add cholesky to torch frontend Dec 8, 2022
@theRealBird theRealBird changed the title Add cholesky to torch frontend Added cholesky to torch frontend Dec 8, 2022
@DragosStoican
Copy link
Contributor

Hey @theRealBird 🙂, I will link this to the corresponding issue, but in future you should do this yourself by adding a comment ‘Close #Issue_number’, as explained here

@DragosStoican DragosStoican linked an issue Dec 12, 2022 that may be closed by this pull request
@theRealBird
Copy link
Contributor Author

Hi @DragosStoican, thank you for linking this PR to the relevant issue, I will do this correctly in the future. I have resolved some merge conflicts - could you review the PR? Thanks :)

@theRealBird
Copy link
Contributor Author

@DragosStoican I was hoping we could wrap this up before the planned git push --force on Friday. Thank you so much

@DragosStoican DragosStoican merged commit 5c20f70 into ivy-llc:master Dec 15, 2022
@theRealBird theRealBird deleted the cholesky_updated branch March 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cholesky
3 participants