Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Compilation insructions missing a cd ../ #325

Open
johnsall opened this issue Nov 3, 2021 · 1 comment
Open

Advanced Compilation insructions missing a cd ../ #325

johnsall opened this issue Nov 3, 2021 · 1 comment

Comments

@johnsall
Copy link

johnsall commented Nov 3, 2021

The instructions in the Advanced Compilation section are missing a step to go up a dir after the cmake command. Running make in that folder mseses up the installation

@sarnold
Copy link

sarnold commented Dec 4, 2021

Cmake is a little "finicky" as far as where you run which cmake build commands; it should work both ways, either from the source directory or from a (temp) build directory. In this case there's an extra wrinkle from the subdirectory in the source folder. Also the following examples use the cmake-cleanup PR (see the tox.ini file on that branch).

Example using mjpg-streamer; run all commands from the repo root dir:

cd mjpg-streamer
cmake -S mjpg-streamer-experimental -B build -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DWXP_COMPAT=OFF
cmake --build build --target install -j $(nproc)

or:

Run the build using ctest in a single command:

cd mjpg-streamer/mjpg-streamer-experimental
ctest --build-generator "Unix Makefiles" --build-and-test . build --build-options -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DWXP_COMPAT=OFF --test-command ctest -V --timeout 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants