fix: correct return type #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we use `it-reader` to read fixed-length chunks out of the stream to do the handshake, and then pipe the rest of the stream through the reader, we'll always transform the stream output to `Uint8ArrayList`s before yielding it. Update the types to reflect this.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 232 232
Branches 25 25
=========================================
Hits 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
## [4.1.2](v4.1.1...v4.1.2) (2022-08-11) ### Bug Fixes * correct return type ([#29](#29)) ([50baa15](50baa15))
|
🎉 This PR is included in version 4.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we use
it-readerto read fixed-length chunks out of the stream to do the handshake, and then pipe the rest of the stream through the reader, we'll always transform the stream output toUint8ArrayLists before yielding it.Update the types to reflect this.