Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties: Discarding, Aborting #14

Open
damncabbage opened this issue Nov 16, 2016 · 5 comments
Open

Properties: Discarding, Aborting #14

damncabbage opened this issue Nov 16, 2016 · 5 comments

Comments

@damncabbage
Copy link
Contributor

There are a couple of things that I miss from QuickCheck, but can't figure out how to add without some core changes to Property:

  • ==>: There's no way to Discard a test case; it's either Success or Failure vs [Haskell] QuickCheck's tri-state result.
  • once: There's no equivalent of abort :: Bool; the only cap on the number of times a test is run is all the way back up in check', meaning any change (eg. allowing configuration of the default runner's hardcoded "100 attempts") would be global.

Any thoughts how this should be tackled? My first thought is having Property be more than a newtype, but you might already have an idea as to how you'd tackle this.

@damncabbage
Copy link
Contributor Author

(I note that Haskell-Jack piggybacks on the QuickCheck definitions, so following suit with the definition of Property might've been your intent all along.)

@jacobstanley
Copy link
Owner

I have actually implemented all this in dotnet-jack, so the plan is to port it back in to here.

https://github.com/jystic/dotnet-jack/blob/master/Jack/Property.fs

@damncabbage
Copy link
Contributor Author

damncabbage commented Nov 17, 2016

Ha! Oops. Do you want to do it or shall I?

Edit: Umm. This may be a little too extensive for me to tackle, in light of the Property-is-now-a-Monad plan.

@jacobstanley
Copy link
Owner

Yeah I would rather do it, I'll have a go at it on the weekend if you can wait that long?

@damncabbage
Copy link
Contributor Author

Thanks. 💦 And please take your time; I didn't mean to give the impression that this was something to rush out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants