Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change information about TLS support for the query service #475

Closed
jpkrohling opened this issue Feb 5, 2021 · 5 comments · Fixed by #522
Closed

Change information about TLS support for the query service #475

jpkrohling opened this issue Feb 5, 2021 · 5 comments · Fixed by #522

Comments

@jpkrohling
Copy link
Contributor

In the page linked below, we state that TLS support for the query service is non-existing. For 1.22, we need to state that this is supported if all the pieces of the work done by @rjs211 are merged by then.

https://www.jaegertracing.io/docs/1.21/security/#browser-to-ui

@yurishkuro
Copy link
Member

This was already done in 3e3f229

@tillig
Copy link
Contributor

tillig commented Aug 25, 2021

It appears the text on that change didn't get fixed - the green check says it's available, but the text still says "no TLS/authentication" next to it, which is super confusing.

@yurishkuro
Copy link
Member

@tillig good catch. I think TLS is "yes", but the authentication is still No, right?

Would you like to submit a patch to the docs?

@tillig
Copy link
Contributor

tillig commented Aug 25, 2021

I'm fine to submit that, sure. I don't actually know the answer to which is yes/no, which is why I started looking through the docs and that's how I got here. But I'll submit a patch based on your note above.

@tillig
Copy link
Contributor

tillig commented Aug 25, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants