Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

HTTP errors on flush are not reported #458

Closed
rexxars opened this issue Apr 6, 2021 · 0 comments · Fixed by #459
Closed

HTTP errors on flush are not reported #458

rexxars opened this issue Apr 6, 2021 · 0 comments · Fixed by #459

Comments

@rexxars
Copy link
Contributor

rexxars commented Apr 6, 2021

Requirement - what kind of business use case are you trying to solve?

When using the HTTP sender to send spans to jaeger and the endpoint is not correctly configured, as a developer I want to surface this information so I may address it.

Problem - what in Jaeger blocks you from solving the requirement?

If you have configured an HTTP sender that has a server on the other end that is receiving the request, but rejects the request with an HTTP error either due to a client error (incorrect path, incorrect payload) or a server problem (internal server error, gateway timeouts), no error is logged and the callback on the flush method does not indicate any error.

Proposal - what do you suggest to solve the problem or improve the existing situation?

I propose HTTP errors (status code >= 400) are reported the same way as socket errors: logger.error(message), as well as with the flush callback.

Any open questions to address

None that I can think of.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant