Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse timer duration buckets obtained through reflection #65

Open
objectiser opened this issue Dec 7, 2018 · 1 comment
Open

Parse timer duration buckets obtained through reflection #65

objectiser opened this issue Dec 7, 2018 · 1 comment

Comments

@objectiser
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

PR #63 includes support for defining buckets on Timer and Histogram metric types. The buckets can be statically declared with the metrics and parsed on reflection.

Problem - what in Jaeger blocks you from solving the requirement?

Buckets for histogram metrics are being parsed, but currently not for timer durations.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Parse the timer durations.

Any open questions to address

How should the durations be expressed? For readability it would probably be best as a number + unit (e.g. 1s, 10m)

@yurishkuro
Copy link
Member

How should the durations be expressed? For readability it would probably be best as a number + unit (e.g. 1s, 10m)

Yes, Go has a standard way of representing durations as strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants