Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes around values #571

Closed
smanolloff opened this issue May 11, 2020 · 2 comments · Fixed by #587
Closed

Remove quotes around values #571

smanolloff opened this issue May 11, 2020 · 2 comments · Fixed by #587

Comments

@smanolloff
Copy link
Contributor

smanolloff commented May 11, 2020

Currently, all values are surrounded by double quotes. This is redundant and, more importantly, confusing, when the message itself contains such quotes:

Screenshot 2020-05-11 at 15 33 10

@tiffon
Copy link
Member

tiffon commented May 11, 2020

Thanks for creating this ticket.

Only string values are surrounded by double-quotes. The double-quotes are meant to indicate the value is a string. For instance, without them, the "400" would look like a number when it's actually a string. And, if the underlying value of the "400" were instead a number (e.g. 400) it would not have the quotes.

For the second log message, the value is a string that itself contains double-quotes. Would it be less confusing if the inner quotes were escaped?

@smanolloff
Copy link
Contributor Author

For the second log message, the value is a string that itself contains double-quotes. Would it be less confusing if the inner quotes were escaped?

Certainly not. Isn't there a way to indicate value types via on-mouse-hover tooltip, or just via the value's text color (eg. blueish for numbers, brown-ish for strings, whatever)?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants