Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger clients should generate full-length trace/span IDs #1657

Closed
5 of 6 tasks
yurishkuro opened this issue Jul 6, 2019 · 3 comments
Closed
5 of 6 tasks

Jaeger clients should generate full-length trace/span IDs #1657

yurishkuro opened this issue Jul 6, 2019 · 3 comments
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement meta-issue An tracking issue that requires work in other repos

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jul 6, 2019

Requirement - what kind of business use case are you trying to solve?

As a user, I should be able to use Trace/span IDs encoded in the trace context (e.g. uber-trace-id header) or exposed via SpanContext.toTraceID() methods to refer to traces in the UI.

Problem - what in Jaeger blocks you from solving the requirement?

Currently, many Jaeger clients drop leading zeroes from hex representation of trace/span IDs, resulting in inconsistent strings returned in JSON to the UI (relates to #1578). This is done as an optimization of the trace context header length, but it's a silly one since it only affects about 1/16th of all traces.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Client libraries should always output hex strings of 16 or 32 characters in length, depending on on whether 64bit or 128bit IDs are used, padded with zeros on the left to the desired length.

For backwards compatibility, clients should still be able to parse shorted hex strings.

@SezalAgrawal
Copy link

Is this issue resolved?

@yurishkuro
Copy link
Member Author

It is not, see the checklist in the description.

@yurishkuro
Copy link
Member Author

Per #3362, we're sunsetting Jaeger clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement meta-issue An tracking issue that requires work in other repos
Projects
None yet
Development

No branches or pull requests

3 participants