Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict clock skew adjustment to a certain max delta #2053

Closed
yurishkuro opened this issue Feb 2, 2020 · 3 comments · Fixed by #2119
Closed

Restrict clock skew adjustment to a certain max delta #2053

yurishkuro opened this issue Feb 2, 2020 · 3 comments · Fixed by #2119

Comments

@yurishkuro
Copy link
Member

Similar to #961, perhaps we should impose a limit on the skew adjustment, e.g. no more than 1s. If the calculated delta exceeds that limit, add a span warning saying that adjustment was not done, and include the proposed delta in the message.

@joe-elliott
Copy link
Member

joe-elliott commented Mar 5, 2020

@yurishkuro I'd be glad to look at this:

Add a param to jaeger-query that takes a duration: --query.max-clock-skew-adjust

Internally default to a negative duration which would maintain current behavior.
Setting to 0 would disable all clock skew adjustment.

@yurishkuro
Copy link
Member Author

I would default to something like 1sec, and use zero as "turn it off" equivalent.

@joe-elliott
Copy link
Member

Sounds good. I'll submit a PR in the next couple days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants