Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated TLS flags #2790

Merged
merged 7 commits into from
Feb 5, 2021

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh [email protected]

Which problem is this PR solving?

Short description of the changes

  • Remove deprecated TLS flags

Signed-off-by: albertteoh <[email protected]>
@albertteoh albertteoh requested a review from a team as a code owner February 5, 2021 04:14
Signed-off-by: albertteoh <[email protected]>
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #2790 (42f4df1) into master (fc888d8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2790      +/-   ##
==========================================
+ Coverage   95.88%   95.90%   +0.02%     
==========================================
  Files         218      218              
  Lines        9615     9606       -9     
==========================================
- Hits         9219     9213       -6     
+ Misses        327      325       -2     
+ Partials       69       68       -1     
Impacted Files Coverage Δ
pkg/config/tlscfg/flags.go 100.00% <ø> (ø)
plugin/storage/integration/integration.go 77.90% <0.00%> (+0.55%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc888d8...2c69c0e. Read the comment docs.

Signed-off-by: albertteoh <[email protected]>
@mergify mergify bot requested a review from jpkrohling February 5, 2021 05:01
@yurishkuro yurishkuro mentioned this pull request Feb 5, 2021
7 tasks
@yurishkuro yurishkuro merged commit 06337c2 into jaegertracing:master Feb 5, 2021
bhiravabhatla pushed a commit to bhiravabhatla/jaeger that referenced this pull request Feb 5, 2021
* Remove deprecated TLS flags

Signed-off-by: albertteoh <[email protected]>

* Add PR ref to changelog

Signed-off-by: albertteoh <[email protected]>

* Fix integration test

Signed-off-by: albertteoh <[email protected]>

* Add changelog deprecate entry for --es.tls

Signed-off-by: albertteoh <[email protected]>

* Add changelog deprecate entries for other storage types

Signed-off-by: albertteoh <[email protected]>

* Add remaining deprecated flags as identified by @yurishkuro

Signed-off-by: albertteoh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants