Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused NewOptionsFromConfig #2866

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

sheetalsingala
Copy link
Contributor

@sheetalsingala sheetalsingala commented Mar 5, 2021

Which problem is this PR solving?

@sheetalsingala sheetalsingala requested a review from a team as a code owner March 5, 2021 14:47
Signed-off-by: sheetalsingala <[email protected]>
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #2866 (58d5af9) into master (2fff3ca) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
+ Coverage   95.89%   95.92%   +0.03%     
==========================================
  Files         223      223              
  Lines        9697     9675      -22     
==========================================
- Hits         9299     9281      -18     
+ Misses        329      325       -4     
  Partials       69       69              
Impacted Files Coverage Δ
plugin/storage/cassandra/options.go 100.00% <ø> (ø)
plugin/storage/es/options.go 100.00% <ø> (ø)
cmd/query/app/server.go 95.62% <0.00%> (-1.46%) ⬇️
plugin/storage/integration/integration.go 77.90% <0.00%> (+0.55%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.92%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fff3ca...58d5af9. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit b950c55 into jaegertracing:master Mar 5, 2021
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused NewOptionsFromConfig
3 participants