Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed v2 directory #2880

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Seed v2 directory #2880

merged 1 commit into from
Mar 15, 2021

Conversation

jpkrohling
Copy link
Contributor

Closes #2837 by creating a v2 directory with the proposed subdirectories. Each leaf contains a .gitkeep file, which should be removed as soon as content is added to them.

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling jpkrohling requested a review from a team as a code owner March 15, 2021 19:16
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling
Copy link
Contributor Author

This PR should create this structure:

$ tree v2
v2
├── agent
│   └── jaegerthriftudp
├── collector
│   ├── jaegerproto
│   └── jaegerthrifthttp
├── internal
├── manifests
├── pkg
├── query
│   ├── extension
│   └── handler
├── remotesampling
│   ├── extension
│   └── handler
└── storage
    ├── badger
    ├── cassandra
    ├── elasticsearch
    ├── grpcplugin
    └── spi

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #2880 (a05ae32) into master (78019b6) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2880      +/-   ##
==========================================
+ Coverage   95.92%   95.95%   +0.03%     
==========================================
  Files         223      223              
  Lines        9685     9685              
==========================================
+ Hits         9290     9293       +3     
+ Misses        327      324       -3     
  Partials       68       68              
Impacted Files Coverage Δ
plugin/storage/badger/spanstore/reader.go 95.37% <0.00%> (-0.72%) ⬇️
plugin/storage/integration/integration.go 77.90% <0.00%> (+0.55%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.92%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78019b6...a05ae32. Read the comment docs.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpkrohling do you know if OTel was ok with moving the jaeger receivers back into jaegertracing as discussed here:

open-telemetry/opentelemetry-collector#2646 (comment)

@jpkrohling
Copy link
Contributor Author

Not yet, I'll ask them during this week's SIG call.

@jpkrohling jpkrohling merged commit bfd3e1b into jaegertracing:master Mar 15, 2021
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
@jpkrohling jpkrohling deleted the jpkrohling/issue2837 branch July 28, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize the code repository to accommodate v2
3 participants