Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post construct interceptor missing an invocation context parameter #448

Closed
manovotn opened this issue Apr 19, 2023 · 1 comment · Fixed by #449
Closed

Post construct interceptor missing an invocation context parameter #448

manovotn opened this issue Apr 19, 2023 · 1 comment · Fixed by #449
Assignees
Labels
accepted Issue/challenge is accepted challenge TCK test challenge

Comments

@manovotn
Copy link
Contributor

manovotn commented Apr 19, 2023

The org.jboss.cdi.tck.interceptors.tests.contract.lifecycleCallback.SheepInterceptor declares a @PostConstruct method which violates interceptor spec requirements.

Namely in this section, the following is stated:

Lifecycle callback interceptor methods declared in an interceptor class or superclass of an interceptor class must have one of the following signatures:

  • void <METHOD>(InvocationContext)
  • Object (InvocationContext)

Here is a link to the current method declaration which lacks the InvocationContext parameter.

The only test using this interceptor asserts that this callback does not get invoked which is probably why it didn't get noticed earlier.

EDIT: I intentionally didn't mark the issue as a challenge but if we encounter an impl having issues with it, it is certainly an option.
After some though, I added the challenge label.

@Ladicek
Copy link
Contributor

Ladicek commented Apr 20, 2023

This is a tiny issue that I believe can't negatively affect anyone, so we can just fix it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue/challenge is accepted challenge TCK test challenge
Projects
None yet
2 participants