From d5b74db7166f44d8eabe409c297103be8bd4bfe6 Mon Sep 17 00:00:00 2001 From: Petr Aubrecht Date: Tue, 28 Jun 2022 14:04:01 +0200 Subject: [PATCH 1/3] specify source level for javadoc --- tck/pom.xml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tck/pom.xml b/tck/pom.xml index 86a33e58..253f9cc5 100644 --- a/tck/pom.xml +++ b/tck/pom.xml @@ -141,6 +141,24 @@ + + org.apache.maven.plugins + maven-javadoc-plugin + 3.4.0 + + + attach-api-javadocs + + jar + + + 11 + true + -Xdoclint:none + + + + From 81806e7a84493e6e81a2c7dd7bd360f20c2b7413 Mon Sep 17 00:00:00 2001 From: Petr Aubrecht Date: Tue, 28 Jun 2022 14:03:29 +0200 Subject: [PATCH 2/3] fix tck javadocs --- .../ee/jakarta/tck/concurrent/framework/TestUtil.java | 2 +- .../tck/concurrent/framework/signaturetest/SigTest.java | 7 ------- .../tck/concurrent/framework/signaturetest/SigTestEE.java | 8 -------- .../framework/signaturetest/SignatureTestDriver.java | 2 +- .../resourcedef/ManagedExecutorDefinitionBean.java | 5 ++--- 5 files changed, 4 insertions(+), 20 deletions(-) diff --git a/tck/src/main/java/ee/jakarta/tck/concurrent/framework/TestUtil.java b/tck/src/main/java/ee/jakarta/tck/concurrent/framework/TestUtil.java index a8c88f7c..a6b4de0f 100644 --- a/tck/src/main/java/ee/jakarta/tck/concurrent/framework/TestUtil.java +++ b/tck/src/main/java/ee/jakarta/tck/concurrent/framework/TestUtil.java @@ -65,7 +65,7 @@ public final class TestUtil { * HTTP convenience method for servlets to get a response from another servlet. * Test clients should extend the {@link TestClient} class that has its own HTTP methods. * - * @param connection - the URLConnection + * @param con - the URLConnection * @return String - response body * @throws IOException */ diff --git a/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SigTest.java b/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SigTest.java index 2ec51a2c..28c239f9 100644 --- a/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SigTest.java +++ b/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SigTest.java @@ -21,14 +21,10 @@ package ee.jakarta.tck.concurrent.framework.signaturetest; -import java.io.BufferedReader; -import java.io.File; -import java.io.InputStreamReader; import java.io.PrintWriter; import java.io.PrintStream; import java.util.ArrayList; -import java.util.Properties; /** * This class should be extended by TCK developers that wish to create a set of @@ -167,9 +163,6 @@ protected String[] getClasses() { * retrieves some state information that is necessary to run the test when when * the test framework invokes the run method (actually the test1 method). * - * @param args List of arguments passed to this test. - * @param p Properties specified by the test user and passed to this test via - * the test framework. * @throws Fault When an error occurs reading or saving the state information * processed by this method. */ diff --git a/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SigTestEE.java b/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SigTestEE.java index 4e57bd6e..9c46991f 100644 --- a/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SigTestEE.java +++ b/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SigTestEE.java @@ -19,7 +19,6 @@ import java.io.BufferedReader; import java.io.File; import java.io.InputStreamReader; -import java.io.IOException; import java.io.PrintWriter; import java.io.PrintStream; @@ -196,13 +195,6 @@ protected String[] getClasses(String vehicleName) { * Called by the test framework to initialize this test. The method simply * retrieves some state information that is necessary to run the test when when * the test framework invokes the run method (actually the test1 method). - * - * @param args List of arguments passed to this test. - * @param p Properties specified by the test user and passed to this test via - * the test framework. - * - * @throws Fault When an error occurs reading or saving the state information - * processed by this method. */ public void setup() { try { diff --git a/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SignatureTestDriver.java b/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SignatureTestDriver.java index 64e8e904..4a39d806 100644 --- a/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SignatureTestDriver.java +++ b/tck/src/main/java/ee/jakarta/tck/concurrent/framework/signaturetest/SignatureTestDriver.java @@ -140,7 +140,7 @@ public void cleanupImpl() throws Exception { /** *

* Execute the signature test. By default, this method passes the result of - * {@link #createTestArguments(String, String, String, String, String)} and + * {@link #createTestArguments(String, String, String, String, String, boolean)} and * passes the result to {@link #runSignatureTest(String, String[])}. * * @param packageListFile - file containing the packages/classes that are diff --git a/tck/src/main/java/ee/jakarta/tck/concurrent/spec/ManagedExecutorService/resourcedef/ManagedExecutorDefinitionBean.java b/tck/src/main/java/ee/jakarta/tck/concurrent/spec/ManagedExecutorService/resourcedef/ManagedExecutorDefinitionBean.java index 0a7477fc..e8c4ac69 100644 --- a/tck/src/main/java/ee/jakarta/tck/concurrent/spec/ManagedExecutorService/resourcedef/ManagedExecutorDefinitionBean.java +++ b/tck/src/main/java/ee/jakarta/tck/concurrent/spec/ManagedExecutorService/resourcedef/ManagedExecutorDefinitionBean.java @@ -15,17 +15,16 @@ */ package ee.jakarta.tck.concurrent.spec.ManagedExecutorService.resourcedef; -import jakarta.annotation.Resource; import jakarta.ejb.Local; import jakarta.ejb.Stateless; import jakarta.enterprise.concurrent.ManagedExecutorDefinition; -import jakarta.enterprise.concurrent.ManagedExecutorService; import javax.naming.InitialContext; import javax.naming.NamingException; /** - * ContextServiceDefinitions are defined under {@link ContextServiceDefinitionBean} + * ContextServiceDefinitions are defined under + * {@link ee.jakarta.tck.concurrent.spec.ContextService.contextPropagate.ContextServiceDefinitionBean} */ @ManagedExecutorDefinition(name = "java:app/concurrent/EJBExecutorA", context = "java:app/concurrent/EJBContextA", From 74d7bd8c3735a01497f151c5e79fbee977242fc5 Mon Sep 17 00:00:00 2001 From: Petr Aubrecht Date: Thu, 30 Jun 2022 10:58:28 +0200 Subject: [PATCH 3/3] change @link to @code in javadoc --- .../jakarta/enterprise/concurrent/ContextServiceDefinition.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/src/main/java/jakarta/enterprise/concurrent/ContextServiceDefinition.java b/api/src/main/java/jakarta/enterprise/concurrent/ContextServiceDefinition.java index cc855c63..ab22ae5d 100644 --- a/api/src/main/java/jakarta/enterprise/concurrent/ContextServiceDefinition.java +++ b/api/src/main/java/jakarta/enterprise/concurrent/ContextServiceDefinition.java @@ -216,7 +216,7 @@ * any global transaction that was previously present there is * first suspended such that the contextual task or action can * begin and manage, as permitted by the container, its own new - * {@link jakarta.transaction.UserTransaction}. + * {@code jakarta.transaction.UserTransaction}. * After the contextual task or action completes, the prior * transaction is resumed on the thread. This is equivalent to * the execution property, {@link ManagedTask#TRANSACTION} with