Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK Challenge Tests with Duplicated Classes #227

Closed
aubi opened this issue May 20, 2022 · 4 comments
Closed

TCK Challenge Tests with Duplicated Classes #227

aubi opened this issue May 20, 2022 · 4 comments
Labels
accepted Accepted certification request challenge TCK challenge
Milestone

Comments

@aubi
Copy link
Contributor

aubi commented May 20, 2022

Specification:

Jakarta Concurrency 3.0.0

Challenged test(s):

ee.jakarta.tck.concurrent.spec.ManagedExecutorService.security.SecurityTests#managedExecutorServiceAPISecurityTest

ee.jakarta.tck.concurrent.spec.ManagedExecutorService.security.SecurityTests#managedScheduledExecutorServiceAPISecurityTest

TCK version:

3.0.0

Tested implementation:

Payara 6 (branch) with Concurrent-RI (branch)

Description

The test have classes SecurityTestRemote and SecurityTestEjb in both jar and war in the same ear, causing deployment issues.

Fixes are available: #218, #221

@njr-11 njr-11 added the challenge TCK challenge label May 20, 2022
@scottmarlow
Copy link

As per TCK Process challenges can take up to 10 days to determine if they should be accepted or denied, so 5 more days left. Having said that, the challenge could be addressed before 10 days.

Also worth quoting what happens if consensus is not reached:
Challenges can be resolved by a specification project lead, or a project challenge triage team, after a consensus of the specification project committers is reached or attempts to gain consensus fails. Specification projects may exercise lazy consensus, voting or any practice that follows the principles of [Eclipse Foundation Development Process](https://www.eclipse.org/projects/dev_process/).

If the challenge is accepted then the challenged test(s) can be excluded and released via a new TCK.

@scottmarlow
Copy link

From discussion in referenced #218 + #221 issues, it sounds like we have identified the test correction.

Also of reference is jakartaee/batch-tck#49 (comment) which discusses how we could make a test change if the Concurrency team thinks the change is safe (e.g. passes any compatible implementations that are possible to run, passing Open Liberty would be enough but other implementation following this conversation could also run independently). If we later discover via subsequent TCK challenges that said safe change was not actually a valid change, the likely approach is to exclude the test and resume updating the test for the next Concurrency major/minor release.

@aubi
Copy link
Contributor Author

aubi commented Jun 10, 2022

I'm convinced, that the fixes are safe, break nothing and could be added to the next version of TCK.

@smillidge smillidge added the accepted Accepted certification request label Jun 27, 2022
@smillidge
Copy link
Contributor

I've accepted the challenge and will disable the test in the 3.0.1 service release of the TCK

@smillidge smillidge added appealed-challenge TCK challenge was appealed accepted Accepted certification request and removed accepted Accepted certification request appealed-challenge TCK challenge was appealed labels Jun 27, 2022
@smillidge smillidge added this to the 3.0.1 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted certification request challenge TCK challenge
Projects
None yet
Development

No branches or pull requests

4 participants