Persistence 3.1/EE Platform 10 TCK challenge for tests that map Character[] or Byte[] but are not testing SQL ARRAY type... #394
Comments
scottmarlow
changed the title
|
The 522 failing TCK tests are shown in the attached jtrfiles.zip although not all of the test results show the deployment failure. |
|
@lukasj could you please add the |
|
@scottmarlow try to employ |
Thanks @lukasj , I pasted an example failure here. Click here to see example deployment failure seen during test running
|
List of challenged tests:
|
|
If not clear from Scott's description, the concern is mapping those array types when The TCK cheats a bit by using all non-null elements. Honestly, since null elements are perfectly legal as elements in these types, the TCK should also test that scenario if it is testing them at all. Why does this matter? E.g. in Hibernate we decided to map these to SQL ARRAY which in our opinion makes the most sense. However, not all databases support SQL ARRAY. E.g. we certify using Derby which does not. Not to mention the discussion about the usefulness of |
|
@lukasj Pending approval of this TCK challenge, we will release updated TCKs as per discussion on jakartaee/platform-tck#1165 to be had. Feedback on the pr is welcome about the TCK change which IMO is independent of accepting the TCK challenge. |
|
Wouldn't be good also to create an issue for Derby? It is quite old, but now it is much easier to fix/improve something. |
If anyone wants to open a jirai, looks like email has to be sent to gain access to the Derby jira issue tracker as per https://db.apache.org/derby/DerbyBugGuidelines.html#Login+to+Jira%2FRequest+a+Jira+userid (I tried the self-sign-up way but that doesn't have The point of this challenge is to also update the TCK to acknowledge that Character[]/Byte[] can better map to SQL ARRAY type due to null support. |
I think we should consider updating Persistence 3.1 TCK tests to not fail with persistence providers that support
SQL Arraymapping.As per https://jakarta.ee/committees/specification/tckprocess:
Persistence Providers that support mapping SQL Array types to Character[] or Byte[] Java fields may see failures like in the attached jtrfiles.zip
I will propose a Platform TCK
10.0.xpull request for changing the related tests which may involve the following files:The same files as above are returned for grep -rl "Byte.*[]"
The text was updated successfully, but these errors were encountered: